-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create postgresql server and db with relevant resources #393
Conversation
…e-server Postgres instance instead
… retired in March 2025
.github/actions/tf-setup/action.yml
Outdated
@@ -50,6 +53,7 @@ runs: | |||
ARM_CLIENT_ID: ${{ inputs.azure-client-id }} | |||
ARM_TENANT_ID: ${{ inputs.azure-tenant-id }} | |||
ARM_SUBSCRIPTION_ID: ${{ inputs.azure-subscription-id }} | |||
ARM_OBJECT_ID: ${{ inputs.azure-object-id }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will still need to add this input as a .tfvar
from the "Load Input Variables" step, under the run
. This is if we are going that route and not using getenv()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait.. does the the azurerm_postgresql_flexible_server
resource not need the object_id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the tenant_id
and the client_id
are needed though right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have been removed. May be added with the next PR with masking the database credentials.
ops/terraform/locals.tf
Outdated
@@ -18,6 +19,7 @@ locals { | |||
appsubnetcidr = "10.1.1.0/24" | |||
websubnetcidr = "10.1.2.0/24" | |||
lbsubnetcidr = "10.1.3.0/24" | |||
dbsubnetcidr = "10.0.4.0/24" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just notice this as well. this cidr will probably need to be 10.1.4.0/24
and not 10.0.4.0/24
to eliminate the chance of crossing on top of each other when both environments are running and to match the pattern of the rest of the cidr's.
Description
Created Postgres Server and One (1) private facing Postgres Database. Taking security measures to ensure the database secrets are not easily accessible.
Screenshots (if applicable)
Related Issues
Checklist